Use correct typing for verify parameter and make sure it's used in the request method. #117
+20
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would solve #94 |
sbasan
approved these changes
Oct 13, 2025
|
@bennnnnnnn we still need to be compatible with python 3.8 verify: bool | strI believe this will solve from typing import Union
verify: Union[bool, str] |
Good point, I've changed this, should be OK now! |
|
@bennnnnnnn flake8 checker is failing - please use pre-commit for auto-formatting :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request summary:
Making sure the verify parameter is correctly typed (it can also be a str as a path to a CA bundle), make sure it's passable to the ManagerSession and make sure it's actually respected in the requests method.
Description of changes:
This allows you to verify the certificate of your vmanage instance against a specific CA bundle (or certifi's trust store, by putting the flag to True). The parameter still defaults to False, so it's a non-breaking change.
Checklist: